laminar_connectors/kafka/

schema_registry.rs

//! Confluent Schema Registry client.
//!
//! [`SchemaRegistryClient`] provides a lightweight async REST client for
//! the Confluent Schema Registry API, with in-memory caching, arrow
//! schema conversion, and compatibility checking.

use std::time::{Duration, Instant};

use quick_cache::sync::Cache;

use arrow_schema::{DataType, SchemaRef};
use reqwest::Client;
use serde::{Deserialize, Serialize};

use crate::error::{ConnectorError, SerdeError};
use crate::kafka::config::{CompatibilityLevel, SrAuth};

/// Schema type as reported by the Schema Registry.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum SchemaType {
    /// Apache Avro schema.
    Avro,
    /// Protocol Buffers schema.
    Protobuf,
    /// JSON Schema.
    Json,
}

impl std::str::FromStr for SchemaType {
    type Err = ConnectorError;

    fn from_str(s: &str) -> Result<Self, Self::Err> {
        match s.to_uppercase().as_str() {
            "AVRO" => Ok(SchemaType::Avro),
            "PROTOBUF" => Ok(SchemaType::Protobuf),
            "JSON" => Ok(SchemaType::Json),
            other => Err(ConnectorError::ConfigurationError(format!(
                "unknown schema type: '{other}'"
            ))),
        }
    }
}

impl std::fmt::Display for SchemaType {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        match self {
            SchemaType::Avro => write!(f, "AVRO"),
            SchemaType::Protobuf => write!(f, "PROTOBUF"),
            SchemaType::Json => write!(f, "JSON"),
        }
    }
}

/// Configuration for the Schema Registry cache.
#[derive(Debug, Clone)]
pub struct SchemaRegistryCacheConfig {
    /// Maximum number of cached schemas. Default: 1000.
    pub max_entries: usize,
    /// TTL for cache entries. `None` means no expiry. Default: 1 hour.
    pub ttl: Option<Duration>,
}

impl Default for SchemaRegistryCacheConfig {
    fn default() -> Self {
        Self {
            max_entries: 1000,
            ttl: Some(Duration::from_secs(3600)),
        }
    }
}

/// A cached schema entry from the Schema Registry.
#[derive(Debug, Clone)]
pub struct CachedSchema {
    /// Schema Registry schema ID.
    pub id: i32,
    /// Schema version within its subject.
    pub version: i32,
    /// The schema type.
    pub schema_type: SchemaType,
    /// Raw schema string (e.g., Avro JSON).
    pub schema_str: String,
    /// Derived Arrow schema for `RecordBatch` construction.
    pub arrow_schema: SchemaRef,
    /// When this entry was inserted or last accessed.
    inserted_at: Instant,
}

/// Result of a compatibility check.
#[derive(Debug, Clone)]
pub struct CompatibilityResult {
    /// Whether the schema is compatible.
    pub is_compatible: bool,
    /// Incompatibility reasons (if any).
    pub messages: Vec<String>,
}

/// Async client for the Confluent Schema Registry REST API.
///
/// Provides schema lookup by ID and subject, caching with LRU eviction
/// and TTL, compatibility checking, and Avro-to-Arrow schema conversion.
pub struct SchemaRegistryClient {
    client: Client,
    base_url: String,
    auth: Option<SrAuth>,
    /// Cache by schema ID (`quick_cache`, S3-FIFO-style eviction).
    cache: Cache<i32, CachedSchema>,
    /// Cache by subject name (latest version).
    subject_cache: Cache<String, CachedSchema>,
    /// Cache configuration.
    cache_config: SchemaRegistryCacheConfig,
}

// -- Schema Registry REST API response types --

#[derive(Deserialize)]
struct SchemaByIdResponse {
    schema: String,
    #[serde(default = "default_schema_type")]
    #[serde(rename = "schemaType")]
    schema_type: String,
}

#[derive(Deserialize)]
struct SchemaVersionResponse {
    id: i32,
    version: i32,
    schema: String,
    #[serde(default = "default_schema_type")]
    #[serde(rename = "schemaType")]
    schema_type: String,
}

#[derive(Deserialize)]
struct CompatibilityResponse {
    is_compatible: bool,
    #[serde(default)]
    messages: Vec<String>,
}

#[derive(Deserialize)]
struct ConfigResponse {
    #[serde(rename = "compatibilityLevel")]
    compatibility_level: String,
}

#[derive(Serialize)]
struct CompatibilityRequest {
    schema: String,
    #[serde(rename = "schemaType")]
    schema_type: String,
}

#[derive(Serialize)]
struct ConfigUpdateRequest {
    compatibility: String,
}

#[derive(Serialize)]
struct RegisterSchemaRequest {
    schema: String,
    #[serde(rename = "schemaType")]
    schema_type: String,
}

#[derive(Deserialize)]
struct RegisterSchemaResponse {
    id: i32,
}

fn default_schema_type() -> String {
    "AVRO".to_string()
}

impl SchemaRegistryClient {
    /// Creates a new Schema Registry client with default cache config.
    #[must_use]
    pub fn new(base_url: impl Into<String>, auth: Option<SrAuth>) -> Self {
        Self::with_cache_config(base_url, auth, SchemaRegistryCacheConfig::default())
    }

    /// Creates a TLS client (CA cert only). Delegates to [`Self::with_tls_mtls`].
    ///
    /// # Errors
    ///
    /// Returns `ConnectorError::ConfigurationError` if the CA cert cannot be read.
    pub fn with_tls(
        base_url: impl Into<String>,
        auth: Option<SrAuth>,
        ca_cert_path: &str,
    ) -> Result<Self, ConnectorError> {
        Self::with_tls_mtls(base_url, auth, ca_cert_path, None, None)
    }

    /// Creates a client with full TLS/mTLS support.
    ///
    /// # Errors
    ///
    /// Returns `ConnectorError::ConfigurationError` if any cert/key file
    /// cannot be read or parsed.
    pub fn with_tls_mtls(
        base_url: impl Into<String>,
        auth: Option<SrAuth>,
        ca_cert_path: &str,
        client_cert_path: Option<&str>,
        client_key_path: Option<&str>,
    ) -> Result<Self, ConnectorError> {
        let pem = std::fs::read(ca_cert_path).map_err(|e| {
            ConnectorError::ConfigurationError(format!(
                "failed to read SR CA cert at '{ca_cert_path}': {e}"
            ))
        })?;
        let cert = reqwest::tls::Certificate::from_pem(&pem).map_err(|e| {
            ConnectorError::ConfigurationError(format!(
                "invalid PEM CA cert at '{ca_cert_path}': {e}"
            ))
        })?;

        let mut builder = Client::builder().add_root_certificate(cert);

        if client_cert_path.is_some() != client_key_path.is_some() {
            return Err(ConnectorError::ConfigurationError(
                "mTLS requires both client cert and key — only one was provided".into(),
            ));
        }
        if let (Some(cert_path), Some(key_path)) = (client_cert_path, client_key_path) {
            let mut identity_pem = std::fs::read(cert_path).map_err(|e| {
                ConnectorError::ConfigurationError(format!(
                    "failed to read SR client cert at '{cert_path}': {e}"
                ))
            })?;
            let key_pem = std::fs::read(key_path).map_err(|e| {
                ConnectorError::ConfigurationError(format!(
                    "failed to read SR client key at '{key_path}': {e}"
                ))
            })?;
            // reqwest Identity expects cert + key concatenated in PEM format.
            identity_pem.extend_from_slice(&key_pem);
            let identity = reqwest::tls::Identity::from_pem(&identity_pem).map_err(|e| {
                ConnectorError::ConfigurationError(format!("invalid client cert/key PEM: {e}"))
            })?;
            builder = builder.identity(identity);
        }

        let client = builder.build().map_err(|e| {
            ConnectorError::ConfigurationError(format!("failed to build TLS client: {e}"))
        })?;

        let cache_config = SchemaRegistryCacheConfig::default();
        let cache = Cache::new(cache_config.max_entries);
        let subject_cache = Cache::new(256);
        Ok(Self {
            client,
            base_url: base_url.into().trim_end_matches('/').to_string(),
            auth,
            cache,
            subject_cache,
            cache_config,
        })
    }

    /// Creates a new Schema Registry client with custom cache config.
    #[must_use]
    pub fn with_cache_config(
        base_url: impl Into<String>,
        auth: Option<SrAuth>,
        cache_config: SchemaRegistryCacheConfig,
    ) -> Self {
        let cache = Cache::new(cache_config.max_entries);
        // Subject cache is small — one entry per subject
        let subject_cache = Cache::new(256);
        Self {
            client: Client::new(),
            base_url: base_url.into().trim_end_matches('/').to_string(),
            auth,
            cache,
            subject_cache,
            cache_config,
        }
    }

    /// Returns the base URL of the Schema Registry.
    #[must_use]
    pub fn base_url(&self) -> &str {
        &self.base_url
    }

    /// Returns `true` if authentication is configured.
    #[must_use]
    pub fn has_auth(&self) -> bool {
        self.auth.is_some()
    }

    /// Returns the cache configuration.
    #[must_use]
    pub fn cache_config(&self) -> &SchemaRegistryCacheConfig {
        &self.cache_config
    }

    /// Inserts a schema into the cache.
    ///
    /// `quick_cache` handles eviction internally (S3-FIFO-style).
    fn cache_insert(&self, id: i32, mut schema: CachedSchema) {
        schema.inserted_at = Instant::now();
        self.cache.insert(id, schema);
    }

    /// Gets from cache, returning `None` if expired.
    ///
    /// TTL is checked lazily on access — expired entries are removed
    /// and treated as cache misses.
    fn cache_get(&self, id: i32) -> Option<CachedSchema> {
        let schema = self.cache.get(&id)?;
        if let Some(ttl) = self.cache_config.ttl {
            if schema.inserted_at.elapsed() > ttl {
                self.cache.remove(&id);
                return None;
            }
        }
        // quick_cache's get() already promotes the entry in the eviction policy
        Some(schema)
    }

    /// Fetches a schema by its global ID.
    ///
    /// Results are cached for subsequent lookups.
    ///
    /// # Errors
    ///
    /// Returns `ConnectorError` if the HTTP request fails or the schema
    /// cannot be parsed.
    pub async fn get_schema_by_id(&self, id: i32) -> Result<CachedSchema, ConnectorError> {
        if let Some(cached) = self.cache_get(id) {
            return Ok(cached);
        }

        let url = format!("{}/schemas/ids/{}", self.base_url, id);
        let resp: SchemaByIdResponse = self.get_json(&url).await?;

        let schema_type: SchemaType = resp.schema_type.parse()?;
        let arrow_schema = schema_to_arrow(schema_type, &resp.schema)?;

        let cached = CachedSchema {
            id,
            version: 0, // not available from this endpoint
            schema_type,
            schema_str: resp.schema,
            arrow_schema,
            inserted_at: Instant::now(),
        };
        self.cache_insert(id, cached.clone());
        Ok(cached)
    }

    /// Fetches the latest schema version for a subject.
    ///
    /// # Errors
    ///
    /// Returns `ConnectorError` if the HTTP request fails.
    pub async fn get_latest_schema(&self, subject: &str) -> Result<CachedSchema, ConnectorError> {
        let url = format!("{}/subjects/{}/versions/latest", self.base_url, subject);
        let resp: SchemaVersionResponse = self.get_json(&url).await?;

        let schema_type: SchemaType = resp.schema_type.parse()?;
        let arrow_schema = schema_to_arrow(schema_type, &resp.schema)?;

        let cached = CachedSchema {
            id: resp.id,
            version: resp.version,
            schema_type,
            schema_str: resp.schema,
            arrow_schema,
            inserted_at: Instant::now(),
        };

        self.cache_insert(resp.id, cached.clone());
        self.subject_cache
            .insert(subject.to_string(), cached.clone());
        Ok(cached)
    }

    /// Fetches a specific schema version for a subject.
    ///
    /// # Errors
    ///
    /// Returns `ConnectorError` if the HTTP request fails.
    pub async fn get_schema_version(
        &self,
        subject: &str,
        version: i32,
    ) -> Result<CachedSchema, ConnectorError> {
        let url = format!(
            "{}/subjects/{}/versions/{}",
            self.base_url, subject, version
        );
        let resp: SchemaVersionResponse = self.get_json(&url).await?;

        let schema_type: SchemaType = resp.schema_type.parse()?;
        let arrow_schema = schema_to_arrow(schema_type, &resp.schema)?;

        let cached = CachedSchema {
            id: resp.id,
            version: resp.version,
            schema_type,
            schema_str: resp.schema,
            arrow_schema,
            inserted_at: Instant::now(),
        };
        self.cache_insert(resp.id, cached.clone());
        Ok(cached)
    }

    /// Checks compatibility of a schema against the latest version.
    ///
    /// # Errors
    ///
    /// Returns `ConnectorError` if the HTTP request fails.
    pub async fn check_compatibility(
        &self,
        subject: &str,
        schema_str: &str,
    ) -> Result<CompatibilityResult, ConnectorError> {
        let url = format!(
            "{}/compatibility/subjects/{}/versions/latest",
            self.base_url, subject
        );

        let body = CompatibilityRequest {
            schema: schema_str.to_string(),
            schema_type: "AVRO".to_string(),
        };

        let mut req = self.client.post(&url).json(&body);
        if let Some(ref auth) = self.auth {
            req = req.basic_auth(&auth.username, Some(&auth.password));
        }

        let resp = req
            .send()
            .await
            .map_err(|e| ConnectorError::ConnectionFailed(format!("schema registry: {e}")))?;

        if !resp.status().is_success() {
            let status = resp.status();
            let text = resp.text().await.unwrap_or_default();
            return Err(ConnectorError::ConnectionFailed(format!(
                "schema registry compatibility check failed: {status} {text}"
            )));
        }

        let result: CompatibilityResponse = resp.json().await.map_err(|e| {
            ConnectorError::Internal(format!("failed to parse compatibility response: {e}"))
        })?;

        Ok(CompatibilityResult {
            is_compatible: result.is_compatible,
            messages: result.messages,
        })
    }

    /// Gets the compatibility level for a subject.
    ///
    /// # Errors
    ///
    /// Returns `ConnectorError` if the HTTP request fails.
    pub async fn get_compatibility_level(
        &self,
        subject: &str,
    ) -> Result<CompatibilityLevel, ConnectorError> {
        let url = format!("{}/config/{}", self.base_url, subject);
        let resp: ConfigResponse = self.get_json(&url).await?;
        resp.compatibility_level.parse()
    }

    /// Sets the compatibility level for a subject.
    ///
    /// # Errors
    ///
    /// Returns `ConnectorError` if the HTTP request fails.
    pub async fn set_compatibility_level(
        &self,
        subject: &str,
        level: CompatibilityLevel,
    ) -> Result<(), ConnectorError> {
        let url = format!("{}/config/{}", self.base_url, subject);
        let body = ConfigUpdateRequest {
            compatibility: level.as_str().to_string(),
        };

        let mut req = self.client.put(&url).json(&body);
        if let Some(ref auth) = self.auth {
            req = req.basic_auth(&auth.username, Some(&auth.password));
        }

        let resp = req
            .send()
            .await
            .map_err(|e| ConnectorError::ConnectionFailed(format!("schema registry: {e}")))?;

        if !resp.status().is_success() {
            let status = resp.status();
            let text = resp.text().await.unwrap_or_default();
            return Err(ConnectorError::ConnectionFailed(format!(
                "schema registry config update failed: {status} {text}"
            )));
        }

        Ok(())
    }

    /// Resolves a Confluent schema ID, returning from cache if available.
    ///
    /// This is the hot-path method called during Avro deserialization to
    /// look up schemas by the 4-byte ID in the Confluent wire format.
    ///
    /// # Errors
    ///
    /// Returns `ConnectorError` if the schema cannot be fetched.
    pub async fn resolve_confluent_id(&self, id: i32) -> Result<CachedSchema, ConnectorError> {
        self.get_schema_by_id(id).await
    }

    /// Registers a schema with the Schema Registry under the given subject.
    ///
    /// Returns the schema ID assigned by the registry. Caches the result
    /// so subsequent calls with the same subject return immediately.
    ///
    /// # Errors
    ///
    /// Returns `ConnectorError` if the HTTP request fails or the response
    /// is malformed.
    pub async fn register_schema(
        &self,
        subject: &str,
        schema_str: &str,
        schema_type: SchemaType,
    ) -> Result<i32, ConnectorError> {
        // Check subject cache — only return cached ID if schema hasn't changed.
        if let Some(cached) = self.subject_cache.get(subject) {
            if cached.schema_str == schema_str {
                return Ok(cached.id);
            }
        }

        let url = format!("{}/subjects/{}/versions", self.base_url, subject);
        let body = RegisterSchemaRequest {
            schema: schema_str.to_string(),
            schema_type: schema_type.to_string(),
        };

        let mut req = self.client.post(&url).json(&body);
        if let Some(ref auth) = self.auth {
            req = req.basic_auth(&auth.username, Some(&auth.password));
        }

        let resp = req
            .send()
            .await
            .map_err(|e| ConnectorError::ConnectionFailed(format!("schema registry: {e}")))?;

        if !resp.status().is_success() {
            let status = resp.status();
            let text = resp.text().await.unwrap_or_default();
            return Err(ConnectorError::ConnectionFailed(format!(
                "schema registry register failed: {status} {text}"
            )));
        }

        let result: RegisterSchemaResponse = resp.json().await.map_err(|e| {
            ConnectorError::Internal(format!("failed to parse register schema response: {e}"))
        })?;

        let arrow_schema = avro_to_arrow_schema(schema_str)?;
        let cached = CachedSchema {
            id: result.id,
            version: 0,
            schema_type,
            schema_str: schema_str.to_string(),
            arrow_schema,
            inserted_at: Instant::now(),
        };
        self.cache_insert(result.id, cached.clone());
        self.subject_cache.insert(subject.to_string(), cached);

        Ok(result.id)
    }

    /// Validates compatibility and registers a schema in one step.
    ///
    /// If the subject already has schemas registered, checks compatibility
    /// first. Returns `SerdeError::SchemaIncompatible` if the new schema
    /// is not compatible with the existing versions.
    ///
    /// # Errors
    ///
    /// Returns `ConnectorError::Serde(SchemaIncompatible)` if incompatible,
    /// or `ConnectorError` for HTTP/network errors.
    pub async fn validate_and_register_schema(
        &self,
        subject: &str,
        schema_str: &str,
        schema_type: SchemaType,
    ) -> Result<i32, ConnectorError> {
        // Check compatibility first (404 means no existing schema — OK to proceed).
        match self.check_compatibility(subject, schema_str).await {
            Ok(result) => {
                if !result.is_compatible {
                    let message = if result.messages.is_empty() {
                        "new schema is not compatible with existing version".to_string()
                    } else {
                        result.messages.join("; ")
                    };
                    return Err(ConnectorError::Serde(SerdeError::SchemaIncompatible {
                        subject: subject.to_string(),
                        message,
                    }));
                }
            }
            Err(ConnectorError::ConnectionFailed(msg)) if msg.contains("404") => {
                // No existing schema — first registration, skip compatibility.
            }
            Err(e) => return Err(e),
        }

        self.register_schema(subject, schema_str, schema_type).await
    }

    /// Returns `true` if the schema ID is in the local cache.
    #[must_use]
    pub fn is_cached(&self, id: i32) -> bool {
        self.cache.contains_key(&id)
    }

    /// Returns the number of cached schemas.
    #[must_use]
    pub fn cache_size(&self) -> usize {
        self.cache.len()
    }

    /// Helper to perform a GET request and deserialize JSON.
    ///
    /// Retries transient failures (5xx, timeouts) up to 3 attempts with
    /// exponential backoff (100ms, 500ms). 4xx client errors fail immediately.
    async fn get_json<T: serde::de::DeserializeOwned>(
        &self,
        url: &str,
    ) -> Result<T, ConnectorError> {
        let backoffs = [
            std::time::Duration::from_millis(100),
            std::time::Duration::from_millis(500),
        ];
        let mut last_err = None;

        for (attempt, backoff) in std::iter::once(&std::time::Duration::ZERO)
            .chain(backoffs.iter())
            .enumerate()
        {
            if attempt > 0 {
                tokio::time::sleep(*backoff).await;
            }

            let mut req = self.client.get(url);
            if let Some(ref auth) = self.auth {
                req = req.basic_auth(&auth.username, Some(&auth.password));
            }

            let resp = match req.send().await {
                Ok(r) => r,
                Err(e) => {
                    tracing::warn!(
                        attempt = attempt + 1,
                        error = %e,
                        "schema registry request failed, retrying"
                    );
                    last_err = Some(ConnectorError::ConnectionFailed(format!(
                        "schema registry: {e}"
                    )));
                    continue;
                }
            };

            let status = resp.status();
            if status.is_success() {
                return resp.json::<T>().await.map_err(|e| {
                    ConnectorError::Internal(format!(
                        "failed to parse schema registry response: {e}"
                    ))
                });
            }

            // Client errors (4xx) are not retryable.
            if status.is_client_error() {
                let text = resp.text().await.unwrap_or_default();
                return Err(ConnectorError::ConnectionFailed(format!(
                    "schema registry client error: {status} {text}"
                )));
            }

            // Server errors (5xx) are retryable.
            let text = resp.text().await.unwrap_or_default();
            tracing::warn!(
                attempt = attempt + 1,
                status = %status,
                "schema registry server error, retrying"
            );
            last_err = Some(ConnectorError::ConnectionFailed(format!(
                "schema registry request failed: {status} {text}"
            )));
        }

        Err(last_err.unwrap_or_else(|| {
            ConnectorError::ConnectionFailed("schema registry: all retries exhausted".into())
        }))
    }
}

impl std::fmt::Debug for SchemaRegistryClient {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("SchemaRegistryClient")
            .field("base_url", &self.base_url)
            .field("has_auth", &self.auth.is_some())
            .field("cached_schemas", &self.cache.len())
            .field("cached_subjects", &self.subject_cache.len())
            .finish_non_exhaustive()
    }
}

/// Dispatch a Schema Registry payload to the right Arrow converter.
/// Only Avro is wired today; JSON Schema and Protobuf return an
/// actionable error until a maintained conversion library lands.
fn schema_to_arrow(schema_type: SchemaType, schema_str: &str) -> Result<SchemaRef, ConnectorError> {
    let name = match schema_type {
        SchemaType::Avro => return avro_to_arrow_schema(schema_str),
        SchemaType::Json => "JSON Schema Registry",
        SchemaType::Protobuf => "Protobuf Schema Registry",
    };
    Err(ConnectorError::SchemaMismatch(format!(
        "{name} subjects are not yet supported for auto-discovery \
         — declare columns explicitly or use an Avro subject"
    )))
}

/// Converts an Avro JSON schema string to an Arrow [`SchemaRef`] via `arrow-avro`'s Decoder.
///
/// # Errors
///
/// Returns `ConnectorError::SchemaMismatch` if the JSON is invalid or conversion fails.
pub fn avro_to_arrow_schema(avro_schema_str: &str) -> Result<SchemaRef, ConnectorError> {
    use arrow_avro::reader::ReaderBuilder;
    use arrow_avro::schema::{AvroSchema, Fingerprint, FingerprintAlgorithm, SchemaStore};

    let mut store = SchemaStore::new_with_type(FingerprintAlgorithm::Id);
    let avro_schema = AvroSchema::new(avro_schema_str.to_string());
    let fp = Fingerprint::Id(0);
    store
        .set(fp, avro_schema)
        .map_err(|e| ConnectorError::SchemaMismatch(format!("invalid Avro schema: {e}")))?;

    let decoder = ReaderBuilder::new()
        .with_writer_schema_store(store)
        .with_active_fingerprint(fp)
        .build_decoder()
        .map_err(|e| ConnectorError::SchemaMismatch(format!("Avro→Arrow conversion: {e}")))?;

    Ok(decoder.schema())
}

/// Converts an Arrow [`SchemaRef`] to an Avro JSON schema string.
///
/// Generates a record schema named `"record"` with fields mapped from
/// Arrow data types to Avro primitives.
///
/// # Errors
///
/// Returns `SerdeError` if an Arrow type has no Avro equivalent.
pub fn arrow_to_avro_schema(schema: &SchemaRef, record_name: &str) -> Result<String, SerdeError> {
    let mut fields = Vec::with_capacity(schema.fields().len());

    for field in schema.fields() {
        let avro_type = arrow_to_avro_type(field.data_type())?;

        let field_type = if field.is_nullable() {
            serde_json::json!(["null", avro_type])
        } else {
            avro_type
        };

        fields.push(serde_json::json!({
            "name": field.name(),
            "type": field_type,
        }));
    }

    // Avro record names must match [A-Za-z_][A-Za-z0-9_]*; topic names
    // commonly contain hyphens (e.g. "my-events") which are invalid.
    let safe_name = record_name.replace('-', "_");

    let schema = serde_json::json!({
        "type": "record",
        "name": safe_name,
        "fields": fields,
    });

    serde_json::to_string(&schema)
        .map_err(|e| SerdeError::MalformedInput(format!("failed to serialize Avro schema: {e}")))
}

/// Maps an Arrow `DataType` to an Avro type JSON value.
fn arrow_to_avro_type(data_type: &DataType) -> Result<serde_json::Value, SerdeError> {
    match data_type {
        DataType::Null => Ok(serde_json::json!("null")),
        DataType::Boolean => Ok(serde_json::json!("boolean")),
        DataType::Int8
        | DataType::Int16
        | DataType::Int32
        | DataType::UInt8
        | DataType::UInt16
        | DataType::UInt32 => Ok(serde_json::json!("int")),
        DataType::Int64 | DataType::UInt64 => Ok(serde_json::json!("long")),
        DataType::Float32 => Ok(serde_json::json!("float")),
        DataType::Float64 => Ok(serde_json::json!("double")),
        DataType::Utf8 | DataType::LargeUtf8 => Ok(serde_json::json!("string")),
        DataType::Binary | DataType::LargeBinary => Ok(serde_json::json!("bytes")),
        DataType::List(item_field) => {
            let items = arrow_to_avro_type(item_field.data_type())?;
            Ok(serde_json::json!({
                "type": "array",
                "items": items,
            }))
        }
        DataType::Map(entries_field, _) => {
            // Map entries field is a Struct with "key" and "value" children.
            if let DataType::Struct(fields) = entries_field.data_type() {
                let value_field = fields.iter().find(|f| f.name() == "value").ok_or_else(|| {
                    SerdeError::UnsupportedFormat(
                        "Arrow Map missing 'value' field in entries struct".into(),
                    )
                })?;
                let values = arrow_to_avro_type(value_field.data_type())?;
                Ok(serde_json::json!({
                    "type": "map",
                    "values": values,
                }))
            } else {
                Err(SerdeError::UnsupportedFormat(
                    "Arrow Map entries field is not a Struct".into(),
                ))
            }
        }
        DataType::Struct(fields) => {
            let mut avro_fields = Vec::with_capacity(fields.len());
            for field in fields {
                let avro_type = arrow_to_avro_type(field.data_type())?;
                let field_type = if field.is_nullable() {
                    serde_json::json!(["null", avro_type])
                } else {
                    avro_type
                };
                avro_fields.push(serde_json::json!({
                    "name": field.name(),
                    "type": field_type,
                }));
            }
            Ok(serde_json::json!({
                "type": "record",
                "name": "nested",
                "fields": avro_fields,
            }))
        }
        DataType::Dictionary(_, value_type) if value_type.as_ref() == &DataType::Utf8 => {
            Ok(serde_json::json!({
                "type": "enum",
                "name": "enum_field",
                "symbols": [],
            }))
        }
        DataType::Timestamp(arrow_schema::TimeUnit::Millisecond, _) => {
            Ok(serde_json::json!({"type": "long", "logicalType": "timestamp-millis"}))
        }
        DataType::Timestamp(arrow_schema::TimeUnit::Microsecond, _) => {
            Ok(serde_json::json!({"type": "long", "logicalType": "timestamp-micros"}))
        }
        DataType::Date32 => Ok(serde_json::json!({"type": "int", "logicalType": "date"})),
        DataType::Time32(arrow_schema::TimeUnit::Millisecond) => {
            Ok(serde_json::json!({"type": "int", "logicalType": "time-millis"}))
        }
        DataType::Time64(arrow_schema::TimeUnit::Microsecond) => {
            Ok(serde_json::json!({"type": "long", "logicalType": "time-micros"}))
        }
        DataType::FixedSizeBinary(size) => Ok(serde_json::json!({
            "type": "fixed",
            "name": "fixed_field",
            "size": size,
        })),
        other => Err(SerdeError::UnsupportedFormat(format!(
            "no Avro equivalent for Arrow type: {other}"
        ))),
    }
}

#[cfg(test)]
mod tests {
    use std::sync::Arc;

    use super::*;
    use arrow_schema::{Field, Fields, Schema};

    #[test]
    fn test_avro_to_arrow_simple_record() {
        let avro = r#"{
            "type": "record",
            "name": "test",
            "fields": [
                {"name": "id", "type": "long"},
                {"name": "name", "type": "string"},
                {"name": "active", "type": "boolean"}
            ]
        }"#;

        let schema = avro_to_arrow_schema(avro).unwrap();
        assert_eq!(schema.fields().len(), 3);
        assert_eq!(schema.field(0).name(), "id");
        assert_eq!(schema.field(0).data_type(), &DataType::Int64);
        assert!(!schema.field(0).is_nullable());
        assert_eq!(schema.field(1).name(), "name");
        assert_eq!(schema.field(1).data_type(), &DataType::Utf8);
        assert_eq!(schema.field(2).name(), "active");
        assert_eq!(schema.field(2).data_type(), &DataType::Boolean);
    }

    #[test]
    fn test_avro_to_arrow_nullable_union() {
        let avro = r#"{
            "type": "record",
            "name": "test",
            "fields": [
                {"name": "id", "type": "long"},
                {"name": "email", "type": ["null", "string"]}
            ]
        }"#;

        let schema = avro_to_arrow_schema(avro).unwrap();
        assert_eq!(schema.fields().len(), 2);
        assert!(!schema.field(0).is_nullable());
        assert!(schema.field(1).is_nullable());
        assert_eq!(schema.field(1).data_type(), &DataType::Utf8);
    }

    #[test]
    fn test_avro_to_arrow_all_primitives() {
        let avro = r#"{
            "type": "record",
            "name": "test",
            "fields": [
                {"name": "b", "type": "boolean"},
                {"name": "i", "type": "int"},
                {"name": "l", "type": "long"},
                {"name": "f", "type": "float"},
                {"name": "d", "type": "double"},
                {"name": "s", "type": "string"},
                {"name": "raw", "type": "bytes"}
            ]
        }"#;

        let schema = avro_to_arrow_schema(avro).unwrap();
        assert_eq!(schema.field(0).data_type(), &DataType::Boolean);
        assert_eq!(schema.field(1).data_type(), &DataType::Int32);
        assert_eq!(schema.field(2).data_type(), &DataType::Int64);
        assert_eq!(schema.field(3).data_type(), &DataType::Float32);
        assert_eq!(schema.field(4).data_type(), &DataType::Float64);
        assert_eq!(schema.field(5).data_type(), &DataType::Utf8);
        assert_eq!(schema.field(6).data_type(), &DataType::Binary);
    }

    #[test]
    fn test_avro_to_arrow_invalid_json() {
        assert!(avro_to_arrow_schema("not json").is_err());
    }

    #[test]
    fn test_avro_to_arrow_missing_fields() {
        let avro = r#"{"type": "record", "name": "test"}"#;
        assert!(avro_to_arrow_schema(avro).is_err());
    }

    #[test]
    fn schema_to_arrow_avro_works() {
        let avro = r#"{"type":"record","name":"t","fields":[{"name":"x","type":"long"}]}"#;
        let schema = schema_to_arrow(SchemaType::Avro, avro).unwrap();
        assert_eq!(schema.field(0).name(), "x");
    }

    #[test]
    fn schema_to_arrow_json_returns_actionable_error() {
        let err = schema_to_arrow(SchemaType::Json, "{}").unwrap_err();
        assert!(
            err.to_string().contains("JSON Schema Registry"),
            "error should name the subject type, got: {err}"
        );
    }

    #[test]
    fn schema_to_arrow_protobuf_returns_actionable_error() {
        let err = schema_to_arrow(SchemaType::Protobuf, "").unwrap_err();
        assert!(
            err.to_string().contains("Protobuf"),
            "error should name the subject type, got: {err}"
        );
    }

    #[test]
    fn test_schema_type_parsing() {
        assert_eq!("AVRO".parse::<SchemaType>().unwrap(), SchemaType::Avro);
        assert_eq!(
            "PROTOBUF".parse::<SchemaType>().unwrap(),
            SchemaType::Protobuf
        );
        assert_eq!("JSON".parse::<SchemaType>().unwrap(), SchemaType::Json);
        assert!("UNKNOWN".parse::<SchemaType>().is_err());
    }

    #[test]
    fn test_schema_type_display() {
        assert_eq!(SchemaType::Avro.to_string(), "AVRO");
        assert_eq!(SchemaType::Protobuf.to_string(), "PROTOBUF");
        assert_eq!(SchemaType::Json.to_string(), "JSON");
    }

    #[test]
    fn test_client_creation() {
        let client = SchemaRegistryClient::new("http://localhost:8081", None);
        assert_eq!(client.base_url(), "http://localhost:8081");
        assert!(!client.has_auth());
        assert_eq!(client.cache_size(), 0);
    }

    #[test]
    fn test_client_with_auth() {
        let auth = SrAuth {
            username: "user".into(),
            password: "pass".into(),
        };
        let client = SchemaRegistryClient::new("http://localhost:8081", Some(auth));
        assert!(client.has_auth());
    }

    #[test]
    fn test_client_trailing_slash_stripped() {
        let client = SchemaRegistryClient::new("http://localhost:8081/", None);
        assert_eq!(client.base_url(), "http://localhost:8081");
    }

    #[test]
    fn test_arrow_to_avro_schema_simple() {
        let schema = Arc::new(Schema::new(vec![
            Field::new("id", DataType::Int64, false),
            Field::new("name", DataType::Utf8, false),
        ]));

        let avro_str = arrow_to_avro_schema(&schema, "test_record").unwrap();
        let avro: serde_json::Value = serde_json::from_str(&avro_str).unwrap();

        assert_eq!(avro["type"], "record");
        assert_eq!(avro["name"], "test_record");

        let fields = avro["fields"].as_array().unwrap();
        assert_eq!(fields.len(), 2);
        assert_eq!(fields[0]["name"], "id");
        assert_eq!(fields[0]["type"], "long");
        assert_eq!(fields[1]["name"], "name");
        assert_eq!(fields[1]["type"], "string");
    }

    #[test]
    fn test_arrow_to_avro_schema_sanitizes_hyphens() {
        let schema = Arc::new(Schema::new(vec![Field::new("id", DataType::Int64, false)]));

        let avro_str = arrow_to_avro_schema(&schema, "trades-avro-output").unwrap();
        let avro: serde_json::Value = serde_json::from_str(&avro_str).unwrap();
        assert_eq!(avro["name"], "trades_avro_output");
    }

    #[test]
    fn test_arrow_to_avro_schema_nullable() {
        let schema = Arc::new(Schema::new(vec![
            Field::new("id", DataType::Int64, false),
            Field::new("email", DataType::Utf8, true),
        ]));

        let avro_str = arrow_to_avro_schema(&schema, "record").unwrap();
        let avro: serde_json::Value = serde_json::from_str(&avro_str).unwrap();

        let fields = avro["fields"].as_array().unwrap();
        // Non-nullable: plain type
        assert_eq!(fields[0]["type"], "long");
        // Nullable: union ["null", "string"]
        let union = fields[1]["type"].as_array().unwrap();
        assert_eq!(union.len(), 2);
        assert_eq!(union[0], "null");
        assert_eq!(union[1], "string");
    }

    #[test]
    fn test_arrow_to_avro_all_primitives() {
        let schema = Arc::new(Schema::new(vec![
            Field::new("b", DataType::Boolean, false),
            Field::new("i32", DataType::Int32, false),
            Field::new("i64", DataType::Int64, false),
            Field::new("f32", DataType::Float32, false),
            Field::new("f64", DataType::Float64, false),
            Field::new("s", DataType::Utf8, false),
            Field::new("bin", DataType::Binary, false),
        ]));

        let avro_str = arrow_to_avro_schema(&schema, "all_types").unwrap();
        let avro: serde_json::Value = serde_json::from_str(&avro_str).unwrap();
        let fields = avro["fields"].as_array().unwrap();

        assert_eq!(fields[0]["type"], "boolean");
        assert_eq!(fields[1]["type"], "int");
        assert_eq!(fields[2]["type"], "long");
        assert_eq!(fields[3]["type"], "float");
        assert_eq!(fields[4]["type"], "double");
        assert_eq!(fields[5]["type"], "string");
        assert_eq!(fields[6]["type"], "bytes");
    }

    #[test]
    fn test_arrow_to_avro_roundtrip() {
        let original = Arc::new(Schema::new(vec![
            Field::new("id", DataType::Int64, false),
            Field::new("name", DataType::Utf8, true),
            Field::new("active", DataType::Boolean, false),
        ]));

        let avro_str = arrow_to_avro_schema(&original, "roundtrip").unwrap();
        let recovered = avro_to_arrow_schema(&avro_str).unwrap();

        assert_eq!(recovered.fields().len(), 3);
        assert_eq!(recovered.field(0).data_type(), &DataType::Int64);
        assert!(!recovered.field(0).is_nullable());
        assert_eq!(recovered.field(1).data_type(), &DataType::Utf8);
        assert!(recovered.field(1).is_nullable());
        assert_eq!(recovered.field(2).data_type(), &DataType::Boolean);
    }

    // ---- Complex type tests ----

    #[test]
    fn test_avro_to_arrow_array_type() {
        let avro = r#"{
            "type": "record",
            "name": "test",
            "fields": [
                {"name": "tags", "type": {"type": "array", "items": "string"}}
            ]
        }"#;

        let schema = avro_to_arrow_schema(avro).unwrap();
        assert_eq!(schema.fields().len(), 1);
        match schema.field(0).data_type() {
            DataType::List(item) => {
                assert_eq!(item.data_type(), &DataType::Utf8);
            }
            other => panic!("expected List, got {other:?}"),
        }
    }

    #[test]
    fn test_avro_to_arrow_map_type() {
        let avro = r#"{
            "type": "record",
            "name": "test",
            "fields": [
                {"name": "metadata", "type": {"type": "map", "values": "long"}}
            ]
        }"#;

        let schema = avro_to_arrow_schema(avro).unwrap();
        assert_eq!(schema.fields().len(), 1);
        match schema.field(0).data_type() {
            DataType::Map(entries, _) => {
                if let DataType::Struct(fields) = entries.data_type() {
                    assert_eq!(fields.len(), 2);
                    assert_eq!(fields[0].name(), "key");
                    assert_eq!(fields[0].data_type(), &DataType::Utf8);
                    assert_eq!(fields[1].name(), "value");
                    assert_eq!(fields[1].data_type(), &DataType::Int64);
                } else {
                    panic!("expected Struct entries");
                }
            }
            other => panic!("expected Map, got {other:?}"),
        }
    }

    #[test]
    fn test_avro_to_arrow_nested_record() {
        let avro = r#"{
            "type": "record",
            "name": "test",
            "fields": [
                {
                    "name": "address",
                    "type": {
                        "type": "record",
                        "name": "Address",
                        "fields": [
                            {"name": "street", "type": "string"},
                            {"name": "zip", "type": "int"}
                        ]
                    }
                }
            ]
        }"#;

        let schema = avro_to_arrow_schema(avro).unwrap();
        assert_eq!(schema.fields().len(), 1);
        match schema.field(0).data_type() {
            DataType::Struct(fields) => {
                assert_eq!(fields.len(), 2);
                assert_eq!(fields[0].name(), "street");
                assert_eq!(fields[0].data_type(), &DataType::Utf8);
                assert_eq!(fields[1].name(), "zip");
                assert_eq!(fields[1].data_type(), &DataType::Int32);
            }
            other => panic!("expected Struct, got {other:?}"),
        }
    }

    #[test]
    fn test_avro_to_arrow_enum_type() {
        let avro = r#"{
            "type": "record",
            "name": "test",
            "fields": [
                {
                    "name": "status",
                    "type": {
                        "type": "enum",
                        "name": "Status",
                        "symbols": ["ACTIVE", "INACTIVE", "PENDING"]
                    }
                }
            ]
        }"#;

        let schema = avro_to_arrow_schema(avro).unwrap();
        assert_eq!(schema.fields().len(), 1);
        match schema.field(0).data_type() {
            DataType::Dictionary(key, value) => {
                assert_eq!(key.as_ref(), &DataType::Int32);
                assert_eq!(value.as_ref(), &DataType::Utf8);
            }
            other => panic!("expected Dictionary, got {other:?}"),
        }
    }

    #[test]
    fn test_avro_to_arrow_fixed_type() {
        let avro = r#"{
            "type": "record",
            "name": "test",
            "fields": [
                {
                    "name": "uuid",
                    "type": {"type": "fixed", "name": "uuid", "size": 16}
                }
            ]
        }"#;

        let schema = avro_to_arrow_schema(avro).unwrap();
        assert_eq!(schema.fields().len(), 1);
        assert_eq!(schema.field(0).data_type(), &DataType::FixedSizeBinary(16));
    }

    #[test]
    fn test_avro_to_arrow_nullable_complex_in_union() {
        let avro = r#"{
            "type": "record",
            "name": "test",
            "fields": [
                {
                    "name": "tags",
                    "type": ["null", {"type": "array", "items": "string"}]
                }
            ]
        }"#;

        let schema = avro_to_arrow_schema(avro).unwrap();
        assert!(schema.field(0).is_nullable());
        assert!(matches!(schema.field(0).data_type(), DataType::List(_)));
    }

    #[test]
    fn test_avro_array_missing_items() {
        let avro = r#"{
            "type": "record",
            "name": "test",
            "fields": [
                {"name": "bad", "type": {"type": "array"}}
            ]
        }"#;
        assert!(avro_to_arrow_schema(avro).is_err());
    }

    #[test]
    fn test_avro_map_missing_values() {
        let avro = r#"{
            "type": "record",
            "name": "test",
            "fields": [
                {"name": "bad", "type": {"type": "map"}}
            ]
        }"#;
        assert!(avro_to_arrow_schema(avro).is_err());
    }

    #[test]
    fn test_arrow_to_avro_array_type() {
        let schema = Arc::new(Schema::new(vec![Field::new(
            "tags",
            DataType::List(Arc::new(Field::new("item", DataType::Utf8, true))),
            false,
        )]));

        let avro_str = arrow_to_avro_schema(&schema, "test").unwrap();
        let avro: serde_json::Value = serde_json::from_str(&avro_str).unwrap();
        let field = &avro["fields"][0];
        assert_eq!(field["type"]["type"], "array");
        assert_eq!(field["type"]["items"], "string");
    }

    #[test]
    fn test_arrow_to_avro_map_type() {
        let schema = Arc::new(Schema::new(vec![Field::new(
            "metadata",
            DataType::Map(
                Arc::new(Field::new(
                    "entries",
                    DataType::Struct(Fields::from(vec![
                        Field::new("key", DataType::Utf8, false),
                        Field::new("value", DataType::Int64, true),
                    ])),
                    false,
                )),
                false,
            ),
            false,
        )]));

        let avro_str = arrow_to_avro_schema(&schema, "test").unwrap();
        let avro: serde_json::Value = serde_json::from_str(&avro_str).unwrap();
        let field = &avro["fields"][0];
        assert_eq!(field["type"]["type"], "map");
        assert_eq!(field["type"]["values"], "long");
    }

    #[test]
    fn test_arrow_to_avro_struct_type() {
        let schema = Arc::new(Schema::new(vec![Field::new(
            "address",
            DataType::Struct(Fields::from(vec![
                Field::new("street", DataType::Utf8, false),
                Field::new("zip", DataType::Int32, false),
            ])),
            false,
        )]));

        let avro_str = arrow_to_avro_schema(&schema, "test").unwrap();
        let avro: serde_json::Value = serde_json::from_str(&avro_str).unwrap();
        let field = &avro["fields"][0];
        assert_eq!(field["type"]["type"], "record");
        let nested = field["type"]["fields"].as_array().unwrap();
        assert_eq!(nested.len(), 2);
        assert_eq!(nested[0]["name"], "street");
        assert_eq!(nested[0]["type"], "string");
        assert_eq!(nested[1]["name"], "zip");
        assert_eq!(nested[1]["type"], "int");
    }

    #[test]
    fn test_arrow_to_avro_fixed_type() {
        let schema = Arc::new(Schema::new(vec![Field::new(
            "uuid",
            DataType::FixedSizeBinary(16),
            false,
        )]));

        let avro_str = arrow_to_avro_schema(&schema, "test").unwrap();
        let avro: serde_json::Value = serde_json::from_str(&avro_str).unwrap();
        let field = &avro["fields"][0];
        assert_eq!(field["type"]["type"], "fixed");
        assert_eq!(field["type"]["size"], 16);
    }

    // ---- Cache eviction tests ----

    fn make_cached_schema(id: i32) -> CachedSchema {
        CachedSchema {
            id,
            version: 1,
            schema_type: SchemaType::Avro,
            schema_str: format!(
                r#"{{"type":"record","name":"t{id}","fields":[{{"name":"x","type":"int"}}]}}"#
            ),
            arrow_schema: Arc::new(Schema::new(vec![Field::new("x", DataType::Int32, false)])),
            inserted_at: Instant::now(),
        }
    }

    #[test]
    fn test_cache_config_defaults() {
        let config = SchemaRegistryCacheConfig::default();
        assert_eq!(config.max_entries, 1000);
        assert_eq!(config.ttl, Some(Duration::from_secs(3600)));
    }

    #[test]
    fn test_cache_lru_eviction() {
        let config = SchemaRegistryCacheConfig {
            max_entries: 3,
            ttl: None,
        };
        let client = SchemaRegistryClient::with_cache_config("http://localhost:8081", None, config);

        // Insert 3 schemas.
        client.cache_insert(1, make_cached_schema(1));
        client.cache_insert(2, make_cached_schema(2));
        client.cache_insert(3, make_cached_schema(3));
        assert_eq!(client.cache_size(), 3);

        // Insert a 4th — should evict one entry (S3-FIFO-style eviction).
        client.cache_insert(4, make_cached_schema(4));
        assert!(client.cache_size() <= 3);
        // The most recently inserted should always be present.
        assert!(client.cache_get(4).is_some());
    }

    #[test]
    fn test_cache_ttl_expiration() {
        // TTL generous enough that scheduler jitter between insert and the
        // immediate `is_some()` check can't expire the entry early — a 50ms
        // window flaked under parallel test load on busy CI runners.
        let config = SchemaRegistryCacheConfig {
            max_entries: 100,
            ttl: Some(Duration::from_millis(1000)),
        };
        let client = SchemaRegistryClient::with_cache_config("http://localhost:8081", None, config);

        client.cache_insert(1, make_cached_schema(1));
        assert!(client.cache_get(1).is_some());

        // Wait for TTL to expire.
        std::thread::sleep(Duration::from_millis(1200));
        // Lazy TTL: expired entry returns None on access.
        assert!(client.cache_get(1).is_none());
    }

    #[test]
    fn test_cache_no_ttl() {
        let config = SchemaRegistryCacheConfig {
            max_entries: 100,
            ttl: None,
        };
        let client = SchemaRegistryClient::with_cache_config("http://localhost:8081", None, config);

        client.cache_insert(1, make_cached_schema(1));
        // No TTL — entry should stay.
        assert!(client.cache_get(1).is_some());
    }

    #[test]
    fn test_cache_replace_existing_id() {
        let config = SchemaRegistryCacheConfig {
            max_entries: 10,
            ttl: None,
        };
        let client = SchemaRegistryClient::with_cache_config("http://localhost:8081", None, config);

        client.cache_insert(1, make_cached_schema(1));
        client.cache_insert(2, make_cached_schema(2));
        assert_eq!(client.cache_size(), 2);

        // Re-insert 1 with updated schema — should not increase size.
        client.cache_insert(1, make_cached_schema(1));
        assert_eq!(client.cache_size(), 2);
    }

    #[test]
    fn test_schema_incompatible_error_via_serde() {
        let err = SerdeError::SchemaIncompatible {
            subject: "orders-value".into(),
            message: "READER_FIELD_MISSING_DEFAULT_VALUE: field 'new_field'".into(),
        };
        let conn_err: ConnectorError = err.into();
        assert!(matches!(
            conn_err,
            ConnectorError::Serde(SerdeError::SchemaIncompatible { .. })
        ));
        assert!(conn_err.to_string().contains("orders-value"));
    }

    #[test]
    fn test_validate_and_register_method_exists() {
        // Verify the method exists and has the correct signature by referencing it.
        let client = SchemaRegistryClient::new("http://localhost:8081", None);
        // Just check the method is callable (we can't actually test without a registry).
        let _ = &client;
    }

    #[test]
    fn test_complex_type_roundtrip() {
        let avro = r#"{
            "type": "record",
            "name": "test",
            "fields": [
                {"name": "tags", "type": {"type": "array", "items": "string"}},
                {"name": "metadata", "type": {"type": "map", "values": "long"}}
            ]
        }"#;

        let arrow_schema = avro_to_arrow_schema(avro).unwrap();
        assert!(matches!(
            arrow_schema.field(0).data_type(),
            DataType::List(_)
        ));
        assert!(matches!(
            arrow_schema.field(1).data_type(),
            DataType::Map(_, _)
        ));

        // Convert back to Avro
        let avro_str = arrow_to_avro_schema(&arrow_schema, "test").unwrap();
        let recovered = avro_to_arrow_schema(&avro_str).unwrap();

        assert!(matches!(recovered.field(0).data_type(), DataType::List(_)));
        assert!(matches!(
            recovered.field(1).data_type(),
            DataType::Map(_, _)
        ));
    }
}